Add optional parameter frequency_dimension across wave.resource

MHKiT-Software / MHKiT-Python

MHKiT-Python provides the marine renewable energy (MRE) community tools for data processing, visualization, quality control, resource assessment, and device performance.

https://mhkit-software.github.io/MHKiT/

BSD 3-Clause "New" or "Revised" License

47 stars 45 forks source link

Add optional parameter frequency_dimension across wave.resource #336

Open akeeste opened 5 days ago

akeeste commented 5 days ago

This PR makes the xarray work in wave.resource more consistent by adding the optional parameter frequency_dimension to functions like significant_wave_height that then pass the parameter to frequency_moment.

This is an immediate speed fix for #331 by allowing xarray formats to be passed to all relevant wave.resource functions

ssolson commented 5 days ago

@akeeste in case you are catching up we need to get #335 merged before anything will pass tests due to the numpy 2.0.0 upgrade. (waiting on the wind hindcast rn which is everyone's favorite 5 hour test).