search

MHeasell / rwe

Robot War Engine - Real-time strategy game engine compatible with Total Annihilation
https://www.robotwarengine.com/
GNU General Public License v3.0
116 stars 18 forks source link

Reduce most warnings, remove some unsigned types #100

Closed KevinHake closed 3 years ago

KevinHake commented 3 years ago

I cleared out as much of the low-hanging warnings as I could, while eliminating a lot of unsigned types. The remaining warnings are:

things I think need some genuine attention or further thought before burying things I didn't understand protobufs code... I attempted to set the protobuf include directories as SYSTEM to try to make Visual Studio stop reporting those warnings, but it didn't work. Likely related: https://developercommunity.visualstudio.com/t/visual-studio-with-cmake-cannot-ignore-warnings-fr/1006684 Kind of a bear because it touches everything, but most are very basic changes, tests all passed, the game ran fine for me, and build output is WAY more readable and useful. Hopefully from here we can continue whittling down warnings.

KevinHake commented 3 years ago

I'll break this into more than one piece, for easier review/tracking.