search

MHeasell / rwe

Robot War Engine - Real-time strategy game engine compatible with Total Annihilation
https://www.robotwarengine.com/
GNU General Public License v3.0
115 stars 16 forks source link

ZLib decompress failed for large map pack (V maps.ufo, ) #93

Open KevinHake opened 3 years ago

KevinHake commented 3 years ago

I added the ~2GB "V maps.ufo" (from V maps 26.5.2020.zip, ) to the RWE resources. When I try to select a map, I get a popup dialog, "Critical Error" : "ZLib decompress failed.", and the game exits from there.

MHeasell commented 3 years ago

This is because V Maps was packed with HPIZ Archiver and that program contained a bug that caused it to write bad archives (that TA would still open but modding tools would not).

I submitted a PR to HPIZ Archiver to fix that but we might need to consider mangling the zlib decompress settings in rwe slightly to accommodate this file anyway.

On Thu, 6 May 2021, 21:49 Kevin Hake, @.***> wrote:

I added the ~2GB "V maps.ufo" to the RWE resources. When I try to select a map, I get a "Critical Error" : "ZLib decompress failed."

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/MHeasell/rwe/issues/93, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABUUURH4P2UJCOVE2BMOTNDTML6GTANCNFSM44H4RJEA .

KevinHake commented 3 years ago

oof, that is unfortunate. I guess I'm on the side of "don't fix this" then? The 2 arguments: a) original game doesn't care, so we shouldn't either b) the issue only happened due to a third party tool, in an old version. Allowing these technically broken archives enables perpetuating the use of broken versions. b sounds nice from a "let's make the world a better place" perspective, and it has the added benefit of not requiring any change :P