MHubAI / models

Stores the MHub models dockerfiles and scripts.
MIT License
8 stars 16 forks source link

Added first working FMCIB model container #73

Closed surajpaib closed 8 months ago

surajpaib commented 8 months ago

I tested the default workflow, made some small fixes and it all looks good.

Also tested the slicer workflow on a folder structure that looks like this image

Using the PatientID folder as the lead for the structure. It all works very well 🎆

For the testing, This should pull all the DICOM data: s3://idc-open-data-cr/40db0070-9773-413a-8d7e-c91c37c0006b/* and I'll make a release with the centroids.json and the features.json

surajpaib commented 8 months ago

Hmm, I'm not too sure how you'd want the format to be for these on the release (since we don't have any DICOM + json workflows yet and I am not too sure how to do that myself without spending a lot of time 😓 )

So I've attached both the features.json and the centroids.json for the IDC DICOM scan that I linked above. Maybe you have an idea of how to do this best?

features.json centroids.json

LennyN95 commented 8 months ago

That's great! I'll implement the dicom workflow later today!

surajpaib commented 8 months ago

@LennyN95 Here is another sample.

Image: s3://idc-open-data-cr/18b83380-0f27-42f2-af7c-65e2d23668ac/* Centroid: LUNG1-076_centroids.json Features: LUNG1-076_features.json

LennyN95 commented 8 months ago

/test

sample:
  idc_version: 17.0
  data:
  - SeriesInstanceUID: 1.3.6.1.4.1.32722.99.99.298991776521342375010861296712563382046
    aws_url: s3://idc-open-data-cr/40db0070-9773-413a-8d7e-c91c37c0006b/*
    path: dicom
  - url: https://github.com/MHubAI/models/files/14520712/centroids.json
    path: 1.3.6.1.4.1.32722.99.99.298991776521342375010861296712563382046.json

  - SeriesInstanceUID: 1.3.6.1.4.1.32722.99.99.309695689942006699082558764031786785731
    aws_url: s3://idc-open-data-cr/18b83380-0f27-42f2-af7c-65e2d23668ac/*
    path: dicom
  - url: https://github.com/MHubAI/models/files/14528031/LUNG1-076_centroids.json
    path: 1.3.6.1.4.1.32722.99.99.309695689942006699082558764031786785731.json

reference:
  url: https://github.com/MHubAI/models/files/14612917/fmcib_mhub_default_output.zip

Test Results (24.03.15_11.57.01_d91gDb1QPt) ```yaml id: dbce25f8-eaa8-411f-a4ec-d56e6e9f7df6 date: '2024-03-15 11:57:56' checked_files: - file: features.json path: /app/test/src/1.3.6.1.4.1.32722.99.99.309695689942006699082558764031786785731/features.json checks: - checker: DataFileCheck notes: - label: Value Match description: These keys have identical values info: feature_0,feature_1,feature_2,feature_3,feature_4,feature_5,feature_6,feature_7,feature_8,feature_9,feature_10,feature_11,feature_12,feature_13,feature_14,feature_15,feature_16,feature_17,feature_18,feature_19 (+ 4076 more) - checker: SizeCheck - file: features.json path: /app/test/src/1.3.6.1.4.1.32722.99.99.298991776521342375010861296712563382046/features.json checks: - checker: DataFileCheck notes: - label: Value Match description: These keys have identical values info: feature_0,feature_1,feature_2,feature_3,feature_4,feature_5,feature_6,feature_7,feature_8,feature_9,feature_10,feature_11,feature_12,feature_13,feature_14,feature_15,feature_16,feature_17,feature_18,feature_19 (+ 4076 more) - checker: SizeCheck summary: files_missing: 0 files_extra: 0 checks: DataFileCheck: files: 2 SizeCheck: files: 2 conclusion: true ```