MHumm / DelphiEncryptionCompendium

Cryptographic library for Embarcadero Delphi and potentially for FPC as well
Apache License 2.0
255 stars 66 forks source link

XTEA cipher algorithm broken #10

Closed MHumm closed 3 years ago

MHumm commented 3 years ago

The XTEA cipher algorithm seems to be broken. It differs from the various C-implementations one can find on the internet in so far that brackets are set differently and thus the result differs as well. This is at least the case since DEC V5.2 even if it passes its DUnitTest in DEC 6.0 development, so that also means that the test data is most likely wrong. The source of this test data is unfortunately unclear. It already was that way before I took over maintenance of this library.

A fixed development branch commit should be available soon.

MHumm commented 3 years ago

Last code commit fixed it (at least as far as I can judge) but I have not been able yet to successfully update the DUnit tests for XTEA yet.

MHumm commented 3 years ago

At least basic unit tests are implemented now.

MHumm commented 3 years ago

This issue is fixed with the V6.0 release