Closed ghukill closed 5 years ago
Most jobs have something similar, if not identical to the following, refactor. Consider having CombineJob from models.py handle request.POST directly.
CombineJob
models.py
request.POST
# get job name job_name = request.POST.get('job_name') if job_name == '': job_name = None # get job note job_note = request.POST.get('job_note') if job_note == '': job_note = None # retrieve jobs to merge input_jobs = [ models.Job.objects.get(pk=int(job)) for job in request.POST.getlist('input_job_id') ] logger.debug('analyzing jobs: %s' % input_jobs) # get preferred metadata index mapper index_mapper = request.POST.get('index_mapper') # get requested validation scenarios validation_scenarios = request.POST.getlist('validation_scenario', []) # handle requested record_id transform rits = request.POST.get('rits')
Done (awhile ago).
Most jobs have something similar, if not identical to the following, refactor. Consider having
CombineJob
frommodels.py
handlerequest.POST
directly.