MI-DPLA / combine

Combine /kämˌbīn/ - Metadata Aggregator Platform
MIT License
26 stars 11 forks source link

Record refinement for test scenarios too inclusive #178

Closed ghukill closed 6 years ago

ghukill commented 6 years ago

Unsurprisingly, passing only the db_id is not enough to refine to a specific record. Unless removing ability to search that table, which is not an option, will need another way to refine table results.

See this example where 751 is passed, and is the first record, but the last Record in the table is auto-selected, where 751 must be found somewhere in that Record:

selection_190

It was a quick hack for POF, but needs refinement.

ghukill commented 6 years ago

Also, prohibitively slow.

ghukill commented 6 years ago

Temporary shim: if integer is passed as search term, search db_id directly, else fallback on __contains search of db_id, combine_id, and record_id. No longer searching document at all, just too slow.

But, will likely be mediated by switching to ES searching primarily: https://github.com/WSULib/combine/issues/225