GUI urls using APP_HOST when page is loaded over hostname

MI-DPLA / combine

Combine /kämˌbīn/ - Metadata Aggregator Platform

MIT License

26 stars 11 forks source link

GUI urls using APP_HOST when page is loaded over hostname #310

Closed ghukill closed 4 years ago

ghukill commented 5 years ago

For example, if combine.example.com is the hostname for IP x.x.x.x, and x.x.x.x is set for APP_HOST in localsettings.py, then those URLs will show x.x.x.x on GUI.

Is this a limitation? or should the URLs attempt to parse the requested hostname from the request object?

ghukill commented 5 years ago

Further more, to avoid external lookups, might be prudent to set loopbacks for any configured hostnames so any internal requests in /etc/hosts so combine.example.com are redirected to localhost.

The alternative would require some changes to Django / Livy / Spark URLs, and would hinder the ability to connect to external Spark clusters (though not comon, would be nice to keep that possibility).

ghukill commented 5 years ago

Related #334