MIC-DKFZ / nnUNet

Apache License 2.0
5.9k stars 1.76k forks source link

typos on _0000 #2

Closed JunMa11 closed 5 years ago

JunMa11 commented 5 years ago

Hi @FabianIsensee ,

For today's new commit, shutil.copy(filename, join(output_folder, file_base[:-7] + "_0000.nii.gz"))

it seems _0000 is not necessary, because it has been added in dataset_conversion.

sitk.WriteImage(img_itk, join(img_dir, pat_id + "_0000.nii.gz"))

FabianIsensee commented 5 years ago

Hi Jun Ma, not sure what exactly you mean. Todays commit is intended to split raw data from the decathlon (4d) into splitted data, if applicable. The output of dataset_conversion (the conversion of external challenge data) is splitted already. What I did today is not used there. Best, Fabian

JunMa11 commented 5 years ago

Hi Fabian, Thanks for your quick reply. I'm so sorry for the inconvenience. I make a mistake.

I should put the output of dataset_conversion into splitted_4d_output_dir instead of raw_dataset_dir. If put the converted data into raw_dataset_dir, the output will be with a name of patid _0000_0000.nii.gz.

Best, Jun