Koshao-sys commented 1 year ago

Hi,

This is the link to our project . We are two members in this project with @MICHAELKITH as Student A and @Koshao-sys as Student B and we have split our tasks as below;

Student A: @MICHAELKITH

Login page and registration page (built with Devise)
Food list (displaying a list of food added by the logged-in user, including quantity)
Form to add new food to the list
General shopping list view (showing missing food items for all recipes of the logged-in user, counting total items and price)

Student B: @Koshao-sys

Recipes list (displaying a list of recipes created by the logged-in user)
Recipe details page (including a toggle button to make the recipe public or private)
Ability for the owner of a recipe to delete it
Public recipe list (displaying a list of all public recipes ordered by newest)
Navigation menu to access all pages

Student A and Student B:

Personalizing the design, including colors, typographies, spacings, etc.
Writing unit tests for the individual components they develop.
Writing integration tests to ensure the different pages and functionalities work together seamlessly.
Secure app from n+1 problems.

gemmen29 commented 1 year ago

Hi Team,

Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights 💯

Descriptive info ✔️
Tasks distributed equally ✔️

Required Changes ♻️

[ ] Kindly add a card in the Kanban board that makes sure there are no N+1 queries happening as per this requirement.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

mahbubul14 commented 1 year ago

Project Approved :trophy: :tada:

Hi @Team,

Your project is complete! You have done it exceptionally well. it's time to merge it :100: Congratulations! 🎉

To Highlight :+1:

:heavy_check_mark: Descriptive PR title. :heavy_check_mark: Well-implemented suggested change.

Optional suggestions :arrow_down_small:

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better.

N/A