search

MICS-Lab / scyan

Biology-driven deep generative model for cell-type annotation in cytometry. Scyan is an interpretable model that also corrects batch-effect and can be used for debarcoding or population discovery.
https://mics-lab.github.io/scyan/
BSD 3-Clause "New" or "Revised" License
33 stars 1 forks source link

Is it necessary to pin anndata? #30

Closed grst closed 7 months ago

grst commented 7 months ago

Hi @quentinblampey,

I was wondering if there's a good reason to pin anndata to 0.8? A lot of new features and bugfixes have been added since then and I can't read zarr files that were generated by newer versions of AnnData.

I understand that poetry advocates for these restrictive dependencies, but from scverse perspective, there shouldn't be any reason to pin old versions of anndata. Instead, we recommend setting up the CI to test against release candidates and report back if something breaks.

Cheers, Gregor

quentinblampey commented 7 months ago

Hello @grst,

There is no reason for this, you're right, probably a mistake.

I'll update the dependencies versions in a future release, I'll let you know!

quentinblampey commented 7 months ago

The dependencies are updated in scyan==1.6.1!