MIDA-group / CytoBrowser

CytoBrowser, a JavaScript and Node.js driven environment for fast and accessible collaborative online visualization, assessment, and annotation of very large microscopy images.
GNU General Public License v3.0
16 stars 7 forks source link

Sometimes when switching to new session, 0 annotations gets loaded #232

Closed joakimlindblad closed 2 years ago

joakimlindblad commented 2 years ago

Possible race condition? Seems the server hasn't loaded annotations, but responds to "summary" request with 0 annotations.

joakimlindblad commented 2 years ago

Possibly missing 'this.ongoingLoad.then' on "requestSummary" message received by server

crydell commented 2 years ago

This looks like a correct solution to me. Looks like you're right in that the summary request could come before the ongoing load finishes before this commit, I would assume it became more apparent with a larger annotation file taking longer to load.