search

MIERUNE / ElevationTile4JP

Retrieve Geographical Survey Institute elevation tiles in the screen and convert them to GeoTiff.
https://mierune.co.jp/
GNU General Public License v2.0
5 stars 2 forks source link

Feat/custom extent #33

Closed bordoray closed 2 months ago

bordoray commented 3 months ago

Close #18

Description（変更内容）

image

Manual Testing（手動テスト）

Summary by CodeRabbit

coderabbitai[bot] commented 3 months ago

Walkthrough

ウィジェットの高さを変更し、新しい QgsExtentGroupBox クラスのウィジェットを追加しました。また、get_tiles.py スクリプトでは、QGIS モジュールのインポート、ファイルフィルターと座標参照系（CRS）の設定、キャンバスの範囲処理、メッセージ通知、ズームレベルの計算、座標変換に関する大幅な機能改良が行われました。

Changes

Files Change Summaries
elevation_tile_for_jp_dialog_base.ui ウィジェットの高さを140から355に変更、新しいウィジェットQgsExtentGroupBoxを追加
get_tiles.py QGIS モジュールのインポート、ファイルフィルターと CRS の設定、キャンバス範囲の処理、メッセージ通知、ズームレベル計算、座標変換に関する変更

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant UI
    participant QgsExtentGroupBox
    participant Script as get_tiles.py

    User->>+UI: Open Dialog
    UI->>+QgsExtentGroupBox: Initialize map canvas and CRS
    User->>+QgsExtentGroupBox: Select Extent
    User->>+UI: Set Output File
    User->>+Script: Run processing
    Script->>+QgsExtentGroupBox: Get selected extent
    Script->>Script: Validate inputs, calculate zoom level
    Script-->>User: Show messages and add layers to project

Assessment against linked issues

Objective Addressed Explanation
出力範囲を領域指定できるようにする (#18) ✅
出力ファイル名、出力ファイルの座標系、およびズームレベルの検証 ✅

Poem

🌿🐇
ウィジェット高く、範囲を広げ
新しいボックス、使いやすさ育て
座標変換、ズームも自在
メッセージ優しく、エラーもなく
🐇🌟

Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
nbayashi commented 2 months ago

@bordoray すいませんコンフリクト起きてるようです。（自分が先に#36をマージしちゃったかもしれません） 解消お願いできますか？