MIERUNE / convert_fgd_dem

convert DEM ("xml" or "folder containing .xml" or ".zip containing .xml") to GeoTiff and Terrain RGB (Tiff).
https://mierune.co.jp/
MIT License
1 stars 2 forks source link

Feat/progress bar thread #18

Closed bordoray closed 1 month ago

bordoray commented 1 month ago

Close #0

Description(変更内容)

Summary by CodeRabbit

coderabbitai[bot] commented 1 month ago

Walkthrough

この変更により、Converter クラスが QThread のサブクラスになり、長時間処理を非同期で実行できるようになりました。これにより、ユーザーインターフェイスがブロックされることなく、進捗状況の更新やメッセージの送信が可能になります。また、dem.py では、メタデータ処理の方法が整理され、XMLパスのフィルタリングが改善されました。テストも新しいスレッド処理に対応しました。

Changes

ファイル 変更概要
src/.../converter.py Converter クラスを QThread サブクラスに変更し、run メソッドを追加。進捗を更新するための pyqtSignal を追加し、非同期処理を実装。
src/.../dem.py コンストラクタで contents_to_array メソッドを呼び出すように変更。XMLパスのフィルタリングを改善し、メタデータ収集が明確に。_get_xml_content_list_get_metadata_list に置換。
tests/.../test_converter.py Converter インスタンスをスレッドとして生成し、start() メソッドを呼び出すように変更。テスト実行時のパフォーマンス向上。

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant UI
    participant Converter
    participant DEM

    User->>UI: Convert DEM
    UI->>Converter: Start conversion (start())
    Converter->>DEM: Read XML paths
    DEM-->>Converter: Metadata list
    Converter->>UI: setMaximum
    Converter->>UI: addProgress
    Converter->>UI: postMessage
    Converter->>UI: processFinished

うさぎの詩です。

変化の風が舞い上がり、
新しい道を照らし出す。
スレッドの森で跳ね回り、
進捗の歌を奏でる。
効率の芽、花開く。
みんなで祝おう、わくわくの時を! 🐇✨


Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.