MIERUNE / convert_fgd_dem

convert DEM ("xml" or "folder containing .xml" or ".zip containing .xml") to GeoTiff and Terrain RGB (Tiff).
https://mierune.co.jp/
MIT License
1 stars 2 forks source link

Fix/multi zipfiles submodule #20

Closed bordoray closed 3 months ago

bordoray commented 3 months ago

Related to https://github.com/MIERUNE/QuickDEM4JP/pull/83

Summary by CodeRabbit

coderabbitai[bot] commented 3 months ago

Walkthrough

この変更は、ZIPファイルの処理を改善するために、converter.pydem.pyのメソッドを拡張しました。runメソッドは、複数のZIPファイルパスを処理できるようになり、_unzip_demメソッドはZIPファイルの柔軟な取り扱いを可能にする新しい引数を受け入れます。これにより、XMLファイルの抽出と取得がより効率的になります。

Changes

ファイル 変更内容
src/convert_fgd_dem/converter.py runメソッドが.zip"形式を処理し、複数のZIPファイルパスを扱えるように改良。
src/convert_fgd_dem/dem.py _unzip_demメソッドが新しい引数を受け入れ、動的にZIPファイルを扱えるように改善。複数のZIPファイルを処理し、XMLパスを集約する機能を追加。

Poem

🐇 うさぎの喜びの歌
ZIPが舞い上がる空の下、
新しい道を見つけたよ、
XMLも仲間で集まる、
みんなで手を取り合い、
楽しい作業、心躍る! 🌟


Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.