MIERUNE / convert_fgd_dem

convert DEM ("xml" or "folder containing .xml" or ".zip containing .xml") to GeoTiff and Terrain RGB (Tiff).
https://mierune.co.jp/
MIT License
1 stars 2 forks source link

Add error if output has no data #21

Closed bordoray closed 2 months ago

bordoray commented 2 months ago

Close #0

What I did(変更内容)

related to https://github.com/MIERUNE/QuickDEM4JP/pull/87

Summary by CodeRabbit

coderabbitai[bot] commented 2 months ago

Walkthrough

この変更は、src/convert_fgd_dem/converter.py内のrunメソッドに新しいチェックを追加し、出力されたデジタル標高モデル(DEM)が有効な標高データを含むかどうかを判断します。無効なデータの場合、処理が中断され、エラーメッセージが出力されることで、ユーザーにフィードバックが提供され、より堅牢なエラーハンドリングが実現されます。

Changes

ファイルパス 変更内容概要
src/convert_fgd_dem/converter.py runメソッドにDEMの標高データを評価するチェックを追加。無効な場合は処理を中断し、エラーメッセージを送信する機能を実装。

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Converter
    participant DEM

    User->>Converter: run()
    Converter->>DEM: Check elevation data
    alt No valid data
        Converter->>User: Emit failure signal
        Converter->>Converter: Set process_interrupted = True
    else Valid data found
        Converter->>Converter: Continue processing
    end

Poem

🐰 ぴょんぴょん跳ねて、嬉しさ広がる
新しいチェックで、データは守られる
無効な高さは、もうこわくない!
フィードバック受けて、心も軽やかに
さあ、進もう、夢の中へ! 🌟


Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.