MIERUNE / plateau-gis-converter

A proof of concept GUI and CLI tool for converting PLATEAU's 3D city models (CityGML) of Japan into various geospatial formats, including 3D Tiles, MVT, and GeoPackage.
https://mierune.github.io/plateau-gis-converter/
MIT License
51 stars 10 forks source link

Feature/optimization-atlas-layout (#616) #617

Closed nokonoko1203 closed 1 month ago

nokonoko1203 commented 1 month ago

Close #0

What I did(変更内容)

Notes(連絡事項)

None / なし

Close #0

What I did(変更内容)

Notes(連絡事項)

None / なし

coderabbitai[bot] commented 1 month ago

Walkthrough

新たな機能として、RustとmacOS環境向けの.gitignoreファイルの追加、MITライセンスの導入、READMEファイルの作成が行われました。また、3Dモデル用のMTLおよびOBJファイルの追加、テクスチャアトラス作成のためのRustプログラムやユーティリティが実装され、従来のコード構成が改善されました。これにより、プロジェクトの整理が進み、ユーザー体験が向上します。

Changes

ファイル 変更の概要
atlas-packer/.gitignore RustとmacOS開発環境向けの新しい.gitignoreファイルを追加。
atlas-packer/LICENSE MITライセンスをプロジェクトに追加。
atlas-packer/README.md プロジェクトの目的や使い方を説明するREADMEファイルを作成。
atlas-packer/examples/assets/dice/*.mtl, *.obj 3Dモデル用のMTLおよびOBJファイルを追加し、材質とジオメトリを定義。
atlas-packer/examples/test_pack.rs, test_pack_dice.rs, test_unused_pixels.rs テクスチャアトラスを作成するための新しいRustプログラムを追加。
atlas-packer/src/export.rs テクスチャアトラスのさまざまな形式(WebP, PNG, JPEG)へのエクスポート機能を実装。
atlas-packer/src/lib.rs, pack.rs, place.rs, texture.rs 複数の新しいモジュールを追加し、テクスチャ管理機能を強化。
nusamai/src/lib.rs, mod.rs, obj/material.rs, obj/mod.rs, obj/obj_writer.rs 機能の整理と不要なモジュールや関数を削除し、OBJ書き込み機能を改善。

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant TexturePacker
    participant TextureCache
    participant AtlasExporter

    User->>TexturePacker: テクスチャを追加
    TexturePacker->>TextureCache: テクスチャ取得または挿入
    TexturePacker->>AtlasExporter: アトラスをエクスポート
    AtlasExporter-->>User: アトラスファイルを保存

🐇 うさぎの耳はぴんと立ち、 新しいコードで心が躍る。 アトラスが美しく整い、 開発の道が拓かれる。 さあ、跳んで行こう、この春の空へ! 🌸


Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 967 lines in your changes missing coverage. Please review.

Files Patch % Lines
atlas-packer/src/texture.rs 0.00% 243 Missing :warning:
nusamai/src/sink/obj/mod.rs 0.00% 238 Missing :warning:
atlas-packer/src/place.rs 0.00% 200 Missing :warning:
atlas-packer/src/export.rs 0.00% 127 Missing :warning:
nusamai/src/sink/obj/obj_writer.rs 0.00% 100 Missing :warning:
atlas-packer/src/pack.rs 0.00% 59 Missing :warning:
Additional details and impacted files | [Components](https://app.codecov.io/gh/MIERUNE/plateau-gis-converter/pull/617/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MIERUNE) | Coverage Δ | | |---|---|---| | [GUI](https://app.codecov.io/gh/MIERUNE/plateau-gis-converter/pull/617/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MIERUNE) | `∅ <ø> (∅)` | | | [Backend](https://app.codecov.io/gh/MIERUNE/plateau-gis-converter/pull/617/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MIERUNE) | `76.11% <0.00%> (+13.17%)` | :arrow_up: | | [Libraries](https://app.codecov.io/gh/MIERUNE/plateau-gis-converter/pull/617/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MIERUNE) | `89.82% <ø> (ø)` | |

:loudspeaker: Thoughts on this report? Let us know!

nokonoko1203 commented 1 month ago

修正が必要