search

MIERUNE / plateau-gis-converter

A proof-of-concept tool for converting PLATEAU's 3D city models (CityGML) of Japan into various geospatial formats, including 3D Tiles, MVT, and GeoPackage.
https://mierune.github.io/plateau-gis-converter/
MIT License
56 stars 10 forks source link

表示するLODの最適化 #667

Closed nokonoko1203 closed 1 month ago

nokonoko1203 commented 1 month ago

Close #533

What I did（変更内容）

Notes（連絡事項）

None / なし

coderabbitai[bot] commented 1 month ago

Walkthrough

このプルリクエストでは、ポリゴンのスライスアルゴリズムにいくつかの変更が加えられています。新たにahash::HashSetへの依存関係が追加され、ジオメトリのLOD（詳細レベル）に基づいて処理すべきジオメトリを決定するロジックがslice_to_tiles関数に組み込まれました。また、ジオメトリから抽出されたユニークなLODを格納するための新しい変数available_lodsが作成され、スライス条件が調整されています。FilterLodTransform構造体に対する変更も含まれていますが、主にコメントの書式が変更されています。

Changes

ファイルパス 変更内容
nusamai/src/sink/cesiumtiles/slice.rs - 新関数desired_lodとshould_process_entryを追加。
- LODに基づくスライスロジックの更新。
- available_lods変数の追加。
nusamai/src/transformer/transform/lods.rs - コメントの書式を変更（ダブルクォートからシングルクォートへ）。
- LODフィルタリングモードのロジックは変更なし。

Assessment against linked issues

Objective Addressed Explanation
LODの最適化を実装する (#533) ✅
テクスチャ付き最大LODを取り出すオプションを実装する (#533) ❌ テクスチャに関するオプションが実装されていない。

Possibly related PRs

Suggested labels

Transformer

Suggested reviewers

Poem

うさぎの耳で聞こえた、
LODの旅が始まった。
スライスの道を進むと、
ジオメトリが踊り出すよ。
テクスチャの夢、叶えよう、
新しい世界、見に行こう！ 🐇✨

🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 90.47619% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
nusamai/src/sink/cesiumtiles/slice.rs 92.68% 3 Missing :warning:
nusamai/src/transformer/transform/lods.rs 0.00% 1 Missing :warning:
Additional details and impacted files | [Components](https://app.codecov.io/gh/MIERUNE/plateau-gis-converter/pull/667/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MIERUNE) | Coverage Δ | | |---|---|---| | [GUI](https://app.codecov.io/gh/MIERUNE/plateau-gis-converter/pull/667/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MIERUNE) | `∅ <ø> (∅)` | | | [Backend](https://app.codecov.io/gh/MIERUNE/plateau-gis-converter/pull/667/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MIERUNE) | `74.21% <90.47%> (+0.06%)` | :arrow_up: | | [Libraries](https://app.codecov.io/gh/MIERUNE/plateau-gis-converter/pull/667/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MIERUNE) | `89.78% <ø> (ø)` | |

:loudspeaker: Thoughts on this report? Let us know!