Fix/input scale in UI - Githubissues

MIERUNE / qgis-plugx-plugin

QGIS to Illustrator with PlugX

GNU General Public License v2.0

3 stars 0 forks source link

Fix/input scale in UI #146

Closed bordoray closed 9 months ago

bordoray commented 10 months ago

Issue

close #144

テスト手順:Test

input scale on UI
test with web mercator and other crs

bordoray commented 9 months ago

from this commitment, flickered issue looks not occurs

bordoray commented 9 months ago

@Kanahiro Okay I solved comments

Kanahiro commented 9 months ago

@bordoray the flicker problem occurs even when newest codes. the way to reproduce is same to following: https://github.com/MIERUNE/qgis-plugin-for-plugx/pull/146#pullrequestreview-1609515999

open plugin dialog
set project-crs as EPSG:3857
select zoom in plugin dialog
drag mapcanvas (flicker!)

bordoray commented 9 months ago

Actually it flicker, only after set a scale on plugX UI

bordoray commented 9 months ago

@Kanahiro How it is?

Kanahiro commented 9 months ago

@bordoray the flicker looks remain still... Did you reproduce that on your machine?

https://github.com/MIERUNE/qgis-plugin-for-plugx/assets/20744195/f99636ec-bd52-4094-be0e-cf94d6ee445b

bordoray commented 9 months ago

@Kanahiro Sorry I misunderstood. It still flickering, but I rearrange code to solve other comments.

comments (this is not blocker to merge)

I thought flickering is not blocker to merge and we will solve in separate issue, but I think understood now, that we have to solve flickering issue to merge, right?

Kanahiro commented 9 months ago

the flicker is a blocker for me because:

a goal of this pull-request is to implement the feature to input scale in plugin UI.
but the feature has a bug
the code quality is also important but this is less important that above.

Kanahiro commented 9 months ago

I have understood I mentioned "this is not blocker to merge" and you read this for the feature. Sorry for occuring misunderstanding but I mean the codes (quality) is not blocker and the feature is blocker.

bordoray commented 9 months ago

Okay thanks for clarifying. Sorry for misunderstood, I will debug now.

bordoray commented 9 months ago

@Kanahiro Looks iface.mapCanvas().extentsChanged.disconnect() signal makes the map flickered. https://github.com/MIERUNE/qgis-plugin-for-plugx/pull/146/files#diff-de91a3ce09f7dfdcba68f804df42972a7548fb2157542bd39dad4e6b18bf03dcR299 I am investigating for another approach, but any idea is welcomed ;)

EDIT : FYI this simple command launched in Python console made map flickered even without open plugin UI

bordoray commented 9 months ago

@Kanahiro Okay it should be fixed!