MIERUNE / qgis-plugx-plugin

QGIS to Illustrator with PlugX
GNU General Public License v2.0
3 stars 0 forks source link

Handle hairline #169

Closed bordoray closed 4 months ago

bordoray commented 4 months ago

Issue

close #167

変更内容:Description

テスト手順:Test

Summary by CodeRabbit

coderabbitai[bot] commented 4 months ago

Walkthrough

translator/vector/symbolディレクトリ内の複数のファイルが変更されました。主な変更点は、convert_to_point関数の削除と、新しいget_stroke_width_pt関数の導入に関連しています。これにより、ポリゴンシンボルと線シンボルのアウトライン幅の処理が改善されました。また、QGISのマップキャンバス上で見える「非常に細い線」が、Illustratorでインポートした際にも正しく表示されるようになりました。

Changes

ファイル 変更内容
.../symbol/fill.py, .../symbol/line.py convert_to_point関数の削除とget_stroke_width_pt関数の導入。line.pyではto_rgbaのインポートをto_rgba, get_stroke_width_ptに変更。
.../symbol/marker.py get_stroke_width_pt関数を使用してoutline_widthの計算を更新。

Assessment against linked issues

Objective Addressed Explanation
#167: Fix hairline width -> 0

Poem

🐰✨
細い線、心は広く
変更の風、新たな光を当てる
コードのうさぎ、喜びに飛び跳ねる
Illustratorも見逃さず抱く
細い線の誓い、永遠に変わらず
🌟🌿


Tips ### Chat There are 3 ways to chat with CodeRabbit: - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit-tests for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit tests for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit tests.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json` ### CodeRabbit Discord Community Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback.