MIERUNE / qgis-plugx-plugin

QGIS to Illustrator with PlugX
GNU General Public License v2.0
3 stars 0 forks source link

Handle custom dash pattern #173

Closed bordoray closed 4 weeks ago

bordoray commented 4 weeks ago

Issue

close #172

変更内容:Description

image image

テスト手順:Test

image

Summary by CodeRabbit

coderabbitai[bot] commented 4 weeks ago

Walkthrough

この変更は、translator/vector/symbol/penstyle.py ファイルにおいて、ストロークタイプとカスタムダッシュパターンに基づくペンスタイル生成ロジックを調整するものです。具体的には、ストロークがソリッドでカスタムダッシュパターンが使用されている場合、ストロークタイプを「ダッシュ」に切り替え、カスタムダッシュパターンを適用します。

Changes

ファイル 変更内容
translator/.../penstyle.py ストロークがソリッドでカスタムダッシュパターンが使用されている場合に、ストロークタイプを「ダッシュ」に切り替え、カスタムダッシュパターンを適用するロジックを追加。

Sequence Diagram(s) (Beta)

sequenceDiagram
    participant User
    participant System
    participant PenStyleGenerator

    User->>System: Request to generate pen style
    System->>PenStyleGenerator: Pass symbol layer
    PenStyleGenerator->>System: Check stroke type and custom dash pattern
    alt Stroke is solid and custom dash pattern is used
        PenStyleGenerator->>System: Switch stroke type to "dash" and apply custom dash pattern
    end
    System->>User: Return generated pen style

Assessment against linked issues

Objective (Issue #) Addressed Explanation
Handle customized Dash patterns for lines (#172)

Poem

変更の風が吹く中で、 ペンは踊る、カスタムダッシュのリズムで。 ソリッドな線もダッシュに変わり、 新たなスタイルが地図を飾る。 うさぎは跳ねて、喜びの詩を歌う。


Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.