search

MIND-Lab / OCTIS

OCTIS: Comparing Topic Models is Simple! A python package to optimize and evaluate topic models (accepted at EACL2021 demo track)
MIT License
718 stars 102 forks source link

Update dependencies #117

Closed Yfke closed 2 months ago

Yfke commented 9 months ago

Due to its very specific dependency requirements (exactly equal to specific subversions), this library is starting to become incompatible with other libraries in the ML space. I propose to follow the convention of only requiring a specific major version, and allowing the package manager freedom to decide on the minor version. I don't see specific reasons why OCTIS is not compatible with higher minor versions of gensim, scikit-learn and numpy.

Yfke commented 7 months ago

Thank you for reviewing and approving these changes. I do not have write access to this repo, so I cannot perform the merge myself.

alex-spok commented 5 months ago

I am also facing an issue with the dependencies, and this PR seems to solve them. I think it would solve #114 as well. @silviatti, if you have a moment, can you have a look and merge it? Thanks a lot!

1jamesthompson1 commented 4 months ago

Speaking up again to sa that I am facing this issue and merging this PR would be really helpful! @silviatti or @pietrotrope could you please have a look at this.

I excited to be able to try this properly in my project.

alihashaam commented 2 months ago

@silviatti or @pietrotrope

Can we please merge this PR?

silviatti commented 2 months ago

Hey everyone, thank you for your patience. I couldn't merge this PR because the tests were failing. However, I have fixed the dependencies in a separate branch and merged this into master today (pip install octis==1.14.0 should do the trick). Please let me know if have any issues with the dependencies and I'll try to address them. Finding the right combination wasn't trivial :) I'll close this PR for now