search

MIND-Lab / OCTIS

OCTIS: Comparing Topic Models is Simple! A python package to optimize and evaluate topic models (accepted at EACL2021 demo track)
MIT License
737 stars 106 forks source link

A question about implementation of KLDivergence #51

Closed dopc closed 2 years ago

dopc commented 2 years ago

Hi and thanks for the great work!

https://github.com/MIND-Lab/OCTIS/blob/2f22350f370c798d01f0ccb2ba0a941f5f2606ef/octis/evaluation_metrics/diversity_metrics.py#L221

In this line, the implementation use the function _LOR at this line, but I think it should be the function _KL at that line.

Am I right?

silviatti commented 2 years ago

Hello :) yes, that's correct. It must be a bad cut-and-paste. If you want to make a PR, please do it :) Otherwise, I can fix the issue in the next few days. Thanks,

Silvia

dopc commented 2 years ago

Hey Silvia,

Thanks for your reply. I have opened the PR.