search

MIPS / CI20_linux

Linux kernel source tree with MIPS Creator CI20 (JZ4780 based) board patches/development for upstreaming
Other
54 stars 24 forks source link

Fails to build Octeon kernel #3

Closed jcowgill closed 9 years ago

jcowgill commented 10 years ago

I've just tried to rebuild the full Debian kernel with all the different CPU flavours with the CI20 patches applied. The Loongson flavours build fine but the Octeon flavour fails with:

arch/mips/built-in.o: In function `jz_wait_irqoff':
idle.c:(.text+0x1d118): undefined reference to `r4k_blast_dcache'
idle.c:(.text+0x1d11c): undefined reference to `r4k_blast_dcache'
/home/jcowgill/linux/linux/Makefile:891: recipe for target 'vmlinux' failed

Presumably because arch/mips/mm/c-r4k.c where r4k_blast_dcache is not included in Octeon builds.

ZubairLK commented 10 years ago

Do the ci20 patches break it? Or does mainline 3.16 doesn't build octeon..

You are checking the 3.16 branch right. Not 3.0.8?

jcowgill commented 10 years ago

Yes the ci20 patches break it. Caused by this commit: df7fddc1805cbfdff5c01c175429613057921a80

ZubairLK commented 10 years ago

In arch/mips/kernel/idle.c , r4k_blast_dcache is added as an extern. I guess that causes it. Would it be wise to wrap an ifdef around it for jz4780?

https://github.com/MIPS/CI20_linux/commit/df7fddc1805cbfdff5c01c175429613057921a80#diff-41daf0317d230554ab5e59efee6e8311

ZubairLK commented 9 years ago

closing this issue. as we upstream this won't happen.