search

MIPT-ILab / MDSP

[2009 – 2012] MDSP: functional simulation of a Multimedia Digital Signal Processor
MIT License
3 stars 1 forks source link

Check and fix current disassembling features of funcsim #24

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
FuncSim should have mode of operation when it prints current instruction 
disassembly (or just hex codes in the case it does not have disasm for a 
particular instruction yet)

Original issue reported on code.google.com by grigory....@gmail.com on 15 Nov 2010 at 8:28

GoogleCodeExporter commented 9 years ago 
Disassembler was checked and repaired where it was necessary. Now it prints 
assembler code which we can analyse and understand correctly. Work of these 
features was tested on all-tests.bin (this file contains most of avaliable 
instructions for MDSP at this moment) For more details see r468.

Original comment by plim.the...@gmail.com on 1 Dec 2010 at 10:03

GoogleCodeExporter commented 9 years ago 
I guess you violated our development process. Before you change isuue status 
you must go through code review process, get approve, merge your changes to 
trunk and only then change issue status to "Fixed".

Original comment by yuri.ba...@gmail.com on 1 Dec 2010 at 10:54

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
Indeed, this issue cannot be marked as fixed yet until a code review is 
performed AND until the code is merged to main trunk. This (and any) bug fix 
effectively does not exist to public while it is placed in a branch only. So 
please stick to the procedure.

P.S. mean Google issue tracker deceived me! Sorry, Yuri.

Original comment by grigory....@gmail.com on 2 Dec 2010 at 7:46

GoogleCodeExporter commented 9 years ago 
I'm sorry for violation. I thought Fixed status means that the job was done and 
mentors should verify (as it described in Status field "QA should verify"). So, 
may I merge with the trunk now?

Original comment by plim.the...@gmail.com on 2 Dec 2010 at 12:08

GoogleCodeExporter commented 9 years ago 
Please request a code review from one of mentors. After you get an approval
then you may merge and should close the bug.

Original comment by grigory....@gmail.com on 2 Dec 2010 at 12:24

GoogleCodeExporter commented 9 years ago 
Changes were commited to the trunc. Disassembler works.

Original comment by plim.the...@gmail.com on 3 Dec 2010 at 8:32