MIPT-ILab / MDSP

[2009 – 2012] MDSP: functional simulation of a Multimedia Digital Signal Processor
MIT License
3 stars 1 forks source link

code review for scheduler #32

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
i`ve changed printing methods in the core class

ps some explanation of variable arguments might be usefull

Original issue reported on code.google.com by vladimir...@gmail.com on 28 Nov 2010 at 11:26

GoogleCodeExporter commented 9 years ago
Set review issue status to: Fixed

Original comment by grigory....@gmail.com on 28 Nov 2010 at 2:24

GoogleCodeExporter commented 9 years ago
Approved.

Please check that the following commands work properly 
with new version of funcsim (different amount of steps passed to the sheduler 
on the command line:):

funcsim tests/simple_test.bin 1
funcsim tests/simple_test.bin 8
funcsim tests/simple_test.bin 10
funcsim tests/simple_test.bin 

And, if you think that functions with variable amount of arguments should be 
documented, then write about them in our wiki on some page like 
FuncSimImplementation - that would be a plus one point for you.

And don't forget to change the status of issue8 after the merge.

Original comment by grigory....@gmail.com on 28 Nov 2010 at 2:30