MIPT-ILab / MDSP

[2009 – 2012] MDSP: functional simulation of a Multimedia Digital Signal Processor
MIT License
3 stars 1 forks source link

Code review request #34

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Purpose of code changes on this branch:
Check and fix current disassembling features of funcsim.

When reviewing my code changes, please focus on:
1. Changes in core.cpp. Some pieces of code were deleted (such as checking for 
zero instruction or printing binary codes in inverted form), because they were 
necessary before, but now we have more convenient ways to do that.

2. Changes in operation.cpp are not very important. Most of them are about how 
to present information in disassembled form.

3. Added all-tests.bin. It includes all operations which can be executed at 
this moment.

After the review, I'll merge this branch into:
/trunk

Original issue reported on code.google.com by plim.the...@gmail.com on 2 Dec 2010 at 6:00

GoogleCodeExporter commented 9 years ago

Original comment by grigory....@gmail.com on 2 Dec 2010 at 7:39

GoogleCodeExporter commented 9 years ago
:-) For review requests students should set mentors as issues' owners - that's 
mentors' responsibility to do the review. That's why I swapped Owner and Cc 
fields.

I've done the review.

Original comment by grigory....@gmail.com on 2 Dec 2010 at 7:40