MIPT-ILab / MDSP

[2009 – 2012] MDSP: functional simulation of a Multimedia Digital Signal Processor
MIT License
3 stars 1 forks source link

Make error reporting of funcsim more verbose and clear #6

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Currently funcsim is way too concise about its errors  - it's most often 'cout 
<< "Error!";'. This should be fixed: a real problem should be reported.

Another thing is not to use cout at all. We need a special methods for logging 
the messages, be they warnings, debug infos or critical errors.

The bug owner will be responsible for designing and implementing the new 
logging system and also changing all places in the code that want to report 
something.

Original issue reported on code.google.com by grigory....@gmail.com on 26 Oct 2010 at 4:43

GoogleCodeExporter commented 9 years ago
Over to the maintaner

Original comment by grigory....@gmail.com on 30 Oct 2010 at 3:02

GoogleCodeExporter commented 9 years ago
I suggest for macros' names to use CAPITAL letters.
E.g.:
  ASSERT(x == True, "Message if not valid!");
  ERROR("Some text here");
  WARNING("You sir, I want to take you to a...");

Original comment by yuri.ba...@gmail.com on 8 Nov 2010 at 3:53

GoogleCodeExporter commented 9 years ago
Currently message printing is being made more object-oriented. 
After this work is done we may use wrapping the methods in #define's if this 
would seem reasonable. 

Original comment by grigory....@gmail.com on 8 Nov 2010 at 9:15

GoogleCodeExporter commented 9 years ago
Anyway Grisha please don't allow commits with coding style violations

Original comment by yuri.ba...@gmail.com on 8 Nov 2010 at 9:22

GoogleCodeExporter commented 9 years ago
This task is nont about macroes, its about new class log and its methods 
log::critical() and logg:warning(). No macroes were introduced so far as far as 
I can find. Please point me to the place where the recent code commits violate 
coding styles.

Original comment by grigory....@gmail.com on 8 Nov 2010 at 9:30

GoogleCodeExporter commented 9 years ago
The task was partly committed. Also we dropped the idea to support this feature.

Original comment by grigory....@gmail.com on 1 Sep 2011 at 8:46