MISP / MISP-STIX-Converter

A utility repo to assist with converting between MISP and STIX formats
GNU Lesser General Public License v3.0
64 stars 31 forks source link

Stix import refactored #13

Closed davidonzo closed 7 years ago

davidonzo commented 7 years ago

Main changes: The code has been refactored defining a dedicated function for the following objects:

I think some function definition can be compacted in a single function, but I thing this way should be better to code management's purpose.

All objects listed below now support the "Related_Objects" import, but just for the first level.

Minor changes:

Hope this help and of course I hope to have some usefull suggestion, as usually happened.

Thanks for your time in advance.

FloatingGhost commented 7 years ago

aaaaaaaaaaa I'm getting spammed with emails simply saying "OK" pl0x stop

davidonzo commented 7 years ago

Thank you very much for your time! I'll apply necessary changes ASAP and will open e new pull request, as last time. Are you agree?

Related objects are something terrible, but I need to find a way to import at least the first level.

I'm working on a new function able to parse recursively all related objects without cause e DoS to MISP. But first I need to know if this code is ok for you.

PS: sorry for to much "ok", next time I'll pay more attention :)