MISP / MISP-STIX-Converter

A utility repo to assist with converting between MISP and STIX formats
GNU Lesser General Public License v3.0
64 stars 31 forks source link

Stiximport refactored 2 #14

Closed davidonzo closed 7 years ago

davidonzo commented 7 years ago

Main changes: The code has been refactored defining a dedicated function for the following objects:

I think some function definition can be compacted in a single function, but I thing this way should be better to code management's purpose.

All objects listed below now support the "Related_Objects" import, but just for the first level.

Minor changes:

Applied @FloatingGhost changes requested (I hope by the right way)

Thanks for your time in advance and for your support in code review.

FloatingGhost commented 7 years ago

See this - you've mixed tabs and spaces, and there are some indentation issues

davidonzo commented 7 years ago

Solved: 35ab32b

FloatingGhost commented 7 years ago

thanks <3

davidonzo commented 7 years ago

Thanks to you!