MISP / MISP

MISP (core software) - Open Source Threat Intelligence and Sharing Platform
https://www.misp-project.org/
GNU Affero General Public License v3.0
5.12k stars 1.36k forks source link

Edit object - changing type of the an attribute in an existing object #3509

Closed adulau closed 5 years ago

adulau commented 5 years ago

It would be nice to be able able to change the type of an attribute within an existing object. The edit interface allows to change everything except the type of the attribute.

iglocska commented 5 years ago

That is for a good reason. That would break the object -> attribute relationship.

On Wed, Jul 25, 2018 at 8:15 AM, Alexandre Dulaunoy < notifications@github.com> wrote:

It would be nice to be able able to change the type of an attribute within an existing object. The edit interface allows to change everything except the type of the attribute.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/MISP/MISP/issues/3509, or mute the thread https://github.com/notifications/unsubscribe-auth/ADf6wHVRyQPtcfjVGxaifnM-aVlPIQf4ks5uKAz2gaJpZM4VffqQ .

SteveClement commented 5 years ago

@iglocska thus a non-issue?

adulau commented 5 years ago

Ok so the best option is to delete and add an attribute but if want to keep the same UUID. As example, I have people who are setting up url instead of link. Updating the type makes sense? instead of creating a new attribute.

iglocska commented 5 years ago

Why does the template allow both?

adulau commented 5 years ago

As an example (paste object), a paste url can be used for malicious use (delivering malicious payload) or used for reference as an osint source.

iglocska commented 5 years ago

I don't see how that would change for the paste object though. Currently the paste object has a Url::url field - editing it after the fact would break the relationship if we'd allow it. Would you allow a domain-ip object to be edited to show a filename and a hash instead of domain+ip?

adulau commented 5 years ago

I see the point. So It means we need to have both on the template object depending of the use of the link of the paste. I'll update it.

iglocska commented 5 years ago

Yup, sounds great!