search

MISP / docker-misp

Automated Docker MISP container - Malware Information Sharing Platform and Threat Sharing
BSD 3-Clause "New" or "Revised" License
105 stars 31 forks source link

moving ARG to place where they are first used to get better docker la… #16

Open giedriusramas opened 4 years ago

giedriusramas commented 4 years ago

Moving ARG to the places where they are first used to get better Docker layer reuse. Putting ARG at top of Dockerfile prevent layer re-use.

ventz commented 4 years ago

@giedriusramas Could you please open PR against: https://github.com/harvard-itsecurity/docker-misp/

This repo here is just a read-only clone copy of that repo. All of the development is done there.

Also, could you leave a text comment on top, with - even though they are listed in the README, it would be convenient for someone to see them all in one place.

# User supplied inputs - (see bellow within Dockerfile for real ARGS that you can replace)
# // DO NOT TOUCH HERE - THIS SECTION IS NOT USED - SIMPLY USED AS README //
##################################################################
# ARG MYSQL_MISP_PASSWORD=ChangeThisDefaultPassworda9564ebc3289b7a14551baf8ad5ec60a 
# ARG POSTFIX_RELAY_HOST=localhost  
# ARG MISP_FQDN=localhost   
# ARG MISP_EMAIL=admin@localhost    
# ARG MISP_GPG_PASSWORD=ChangeThisDefaultPasswordXuJBao5Q2bps89LWFqWkKgDZwAFpNHvc
##################################################################
# ^^^ DO NOT TOUCH HERE - THIS SECTION IS NOT USED - SIMPLY USED AS README ^^^