search

MISP / docker-misp

Automated Docker MISP container - Malware Information Sharing Platform and Threat Sharing
BSD 3-Clause "New" or "Revised" License
105 stars 31 forks source link

Changed from ; to && #9

Open Kortho opened 4 years ago

Kortho commented 4 years ago

&& continues the run if the previous command executed correctly, where ; does not and can cause problems

ventz commented 4 years ago

@Kortho This one can cause problems. The reason we actually changed from && to ; is because some commands while executing cleanly do not return 0 (or sometimes even return). Every once in a while this can bite you. Normally, completely agree that you want to reply on "X, Y, Z" happening consecutively, but there are too many moving parts here, and we have seen "non clean" (vs error) codes multiple times show up as randomly as they disappear.