Bootstrap runs as root, so sudo's are not needed

MISP / misp-cloud

misp-cloud - Cloud-ready images of MISP

72 stars 16 forks source link

Bootstrap runs as root, so sudo's are not needed #6

Closed RichieB2B closed 6 years ago

RichieB2B commented 6 years ago

Sudo's are only for gpg that creates several files in .gpg as www-data

0xtf commented 6 years ago

Have you checked the ones that run as www-data for git clone, for example? Makes sense to download code as the owner of the folder as I don't change permissions for that later.

RichieB2B commented 6 years ago

All permissions are reset on line 502. In general it could make sense to run git as a normal user because of ~/.git/config but as this is a fresh Ubuntu image there is not difference between running git as root and www-data really.

0xtf commented 6 years ago

Makes sense. I'll test this out in the build process and merge it after that.

0xtf commented 6 years ago

Tested. Thank you!