MISP / misp-galaxy

Clusters and elements to attach to MISP events or attributes (like threat actors)
https://misp-galaxy.org/
Other
513 stars 257 forks source link

Adding of Firearm and Ammo galaxies #811

Closed o1mate closed 11 months ago

o1mate commented 1 year ago

Firearms and Ammo

Added two new galaxies

  1. An ammunition galaxy containing a list of known sold ammunition ordered by brands
  2. A firearm galaxy containing two clusters (handguns, shotguns) scrapped from a famous vendor and ordered by model names. (Format : Model name - SKU)

    Original project located here

adulau commented 1 year ago

Cool stuff! I see an issue as the cluster for the firearms is not matching the others. The tests are passing because those are not read. Could you add the corresponding galaxy files? I suppose you need one for handguns and one for shotguns instead of the firearms alone. Thank you!

o1mate commented 1 year ago

Thank you for your reply!

We thought that a single firearm galaxy for both handguns and shotguns would be the right solution, and since the tests passed we didn't suspect any issue. We'll make the required changes!

adulau commented 1 year ago

Then you just need to merge the two clusters into a single one and pointing to the same name for the galaxy. Thanks a lot.

o1mate commented 1 year ago

Hello again, We have merged the two clusters as mentioned before. Now there is only one called firearms containing both of the previous clusters.

o1mate commented 1 year ago

Hello, One of the checks failed to validate, but according to the logs it does not seem to be an issue regarding our files. Is there a possibility to re-run the checks ?

adulau commented 11 months ago

Thanks a lot. We did some clean-up due to the duplicate values. Would you be able to share with us the script/scrapper used to generate the JSON? we would like to keep those updated automatically.

o1mate commented 10 months ago

Hello again! The scripts that were used are available at the project's github page.

Thanks a lot for adding our project to MISP!