search

MISP / misp-modules

Modules for expansion services, enrichment, import and export in MISP and other tools.
http://misp.github.io/misp-modules
GNU Affero General Public License v3.0
345 stars 234 forks source link

CVE Module Errors out if CVE is not found #137

Closed jdubp closed 7 years ago

jdubp commented 7 years ago

Using the MISP hover module for a CVE that is not currently in the circl.lu database returns an unaccounted for error. For example: CVE-2017-11292

The URL queried actually returns "null" https://cve.circl.lu/api/cve/CVE-2017-11292

Since there is no JSON returned the module is unable to parse summary.

Traceback (most recent call last): File "/usr/lib/python3.4/site-packages/misp_modules-1.0-py3.4.egg/misp_modules/init.py", line 197, in post response = yield tornado.gen.with_timeout(timeout, self.run_request(jsonpayload)) File "/usr/lib64/python3.4/site-packages/tornado/gen.py", line 1055, in run value = future.result() File "/usr/lib64/python3.4/site-packages/tornado/concurrent.py", line 238, in result raise_exc_info(self._exc_info) File "", line 4, in raise_exc_info File "/usr/lib64/python3.4/concurrent/futures/thread.py", line 54, in run result = self.fn(*self.args, **self.kwargs) File "/usr/lib/python3.4/site-packages/misp_modules-1.0-py3.4.egg/misp_modules/init.py", line 185, in run_request response = mhandlers[x['module']].handler(q=jsonpayload) File "/usr/lib/python3.4/site-packages/misp_modules-1.0-py3.4.egg/misp_modules/modules/expansion/cve.py", line 22, in handler if vulnerability.get('summary'): AttributeError: 'NoneType' object has no attribute 'get'

adulau commented 7 years ago

Nice finding. I'll have a look at it.

adulau commented 7 years ago

Thank you very much. It's now fixed.