MISP / misp-modules

Modules for expansion services, enrichment, import and export in MISP and other tools.
http://misp.github.io/misp-modules
GNU Affero General Public License v3.0
345 stars 234 forks source link

pip install fails: functools32 python_version < "3.0" #280

Closed jerdna-regeiz closed 5 years ago

jerdna-regeiz commented 5 years ago

Hey,

first thanks for MISP! Currently sitting in the training in Hamburg!

I found installing misp-docker due to an error installing misp-modules. The issue seams a dependency on functools32 coming from pymisp in the requested commit and functools32 being not available for py3.

Step 91/129 : RUN pip3 install -I -r REQUIREMENTS
 ---> Running in e52c7cc5d15e
Obtaining file:///opt/misp-modules (from -r REQUIREMENTS (line 2))
Obtaining pybgpranking from git+https://github.com/D4-project/BGP-Ranking.git/@37c97ae252ec4bf1d67733a49d4895c8cb009cf9#egg=pybgpranking&subdirectory=client (from -r REQUIREMENTS (line 3))
  Cloning https://github.com/D4-project/BGP-Ranking.git/ (to 37c97ae252ec4bf1d67733a49d4895c8cb009cf9) to ./src/pybgpranking
  Could not find a tag or branch '37c97ae252ec4bf1d67733a49d4895c8cb009cf9', assuming commit.
Obtaining pyipasnhistory from git+https://github.com/D4-project/IPASN-History.git/@e846cd36fe1ed6b22f60890bba89f84e61b62e59#egg=pyipasnhistory&subdirectory=client (from -r REQUIREMENTS (line 4))
  Cloning https://github.com/D4-project/IPASN-History.git/ (to e846cd36fe1ed6b22f60890bba89f84e61b62e59) to ./src/pyipasnhistory
  Could not find a tag or branch 'e846cd36fe1ed6b22f60890bba89f84e61b62e59', assuming commit.
Obtaining pyintel471 from git+https://github.com/MISP/PyIntel471.git@0df8d51f1c1425de66714b3a5a45edb69b8cc2fc#egg=pyintel471 (from -r REQUIREMENTS (line 5))
  Cloning https://github.com/MISP/PyIntel471.git (to 0df8d51f1c1425de66714b3a5a45edb69b8cc2fc) to ./src/pyintel471
  Could not find a tag or branch '0df8d51f1c1425de66714b3a5a45edb69b8cc2fc', assuming commit.
Obtaining pymisp from git+https://github.com/MISP/PyMISP.git@62e047f3c1972e21aa36a8882bebf4488cdc1f84#egg=pymisp (from -r REQUIREMENTS (line 6))
  Cloning https://github.com/MISP/PyMISP.git (to 62e047f3c1972e21aa36a8882bebf4488cdc1f84) to ./src/pymisp
  Could not find a tag or branch '62e047f3c1972e21aa36a8882bebf4488cdc1f84', assuming commit.
Obtaining uwhois from git+https://github.com/Rafiot/uwhoisd.git@411572840eba4c72dc321c549b36a54ed5cea9de#egg=uwhois&subdirectory=client (from -r REQUIREMENTS (line 7))
  Cloning https://github.com/Rafiot/uwhoisd.git (to 411572840eba4c72dc321c549b36a54ed5cea9de) to ./src/uwhois
  Could not find a tag or branch '411572840eba4c72dc321c549b36a54ed5cea9de', assuming commit.

.
.
.

Collecting functools32; python_version < "3.0" (from pymisp->-r REQUIREMENTS (line 6))
  Downloading https://files.pythonhosted.org/packages/c5/60/6ac26ad05857c601308d8fb9e87fa36d0ebf889423f47c3502ef034365db/functools32-3.2.3-2.tar.gz
    Complete output from command python setup.py egg_info:
    This backport is for Python 2.7 only.

Using the tag 'v2.4.102' instead of the commit hash in REQUIREMENTS fixes the issue (but most likely one should dig deeper and see where the requirement is coming from in the first case).

Cheers, Andrej

Rafiot commented 5 years ago

Not sure where that one comes from, but are you trying to install misp-modules in python 2? If yes, that is the problem.

SHSauler commented 5 years ago

This is not a misp-modules issue but an issue with misp-docker. It does not occur in Harvard's docker or https://github.com/Podictive/MISP-docker. I'd suggest the latter since it has less layers.

Rafiot commented 5 years ago

The docker image fails when installing misp-modules.

And yes, MISP/misp-docker isn't properly maintained.

8ear commented 5 years ago

Hi @jerdna-regeiz, You can also try the following ready misp-modules container https://hub.docker.com/r/dcso/misp-dockerized-misp-modules/. It is an part of a whole environment, but it csn also be used alone.

Kind regards

exenin commented 5 years ago

building docker misp failed - in my dockerfile i added a line to upgrade PIP and also replaced the pinned version of aiohttp ( hope it still works ) RUN cat REQUIREMENTS | sed 's/aiohttp==3.4.4/aiohttp/g' > REQUIREMENTS

this allowed my build to finish