search

MISP / misp-modules

Modules for expansion services, enrichment, import and export in MISP and other tools.
http://misp.github.io/misp-modules
GNU Affero General Public License v3.0
345 stars 234 forks source link

chardet version mismatch 3.0.4 / 4.0.0 #506

Open Kagee opened 3 years ago

Kagee commented 3 years ago

misp-modules has a versioned dependency on chardet 3.0.4 https://github.com/MISP/misp-modules/blob/main/REQUIREMENTS#L30

faup added chardet as a unversioned dependency stricaud/faup@b5c82fb a couple of daus ago, so it defaults to 4.0.0.

A quick read-through of https://github.com/chardet/chardet/releases/tag/4.0.0 indicated that there were no API changes, so misp-modules could in theory swap to 4.0.0?

Example of where this breaks: https://github.com/coolacid/docker-misp/issues/121

Kagee commented 3 years ago

A followup on this - suggest bumping aiohttp to 3.7.4.post0 so that it can use chardet 4.0.0.

Kagee commented 3 years ago

Thismay be fixed in master but not in a tagged version yet.

Kagee commented 3 years ago

https://github.com/MISP/misp-modules/commit/05578b6a0dea60f2e904dff4d2806591fb976083