search

MISP / misp-modules

Modules for expansion services, enrichment, import and export in MISP and other tools.
http://misp.github.io/misp-modules
GNU Affero General Public License v3.0
332 stars 233 forks source link

fix optional field access #630

Closed jthom-vmray closed 10 months ago

jthom-vmray commented 11 months ago

This pull request improves the handling of optional dictionary entries and arguments that could be optional.

jthom-vmray commented 11 months ago

It seems that a few tests are failing, but they are unrelated to my changes, as far as I can tell. Should I make any adjustments to this PR based on these tests, or how would you suggest we proceed? @adulau

adulau commented 10 months ago

Indeed! Thanks for the contribution.