search

MISP / misp-modules

Modules for expansion services, enrichment, import and export in MISP and other tools.
http://misp.github.io/misp-modules
GNU Affero General Public License v3.0
332 stars 233 forks source link

chg: [internal] Add support for orjson #648

Closed JakubOnderka closed 6 months ago

JakubOnderka commented 6 months ago

orjson is optional dependency, that will make parsing and serializing JSON faster.

adulau commented 6 months ago

Question: why do you replace the sys.exit by return ? It’s kind of intended to use an exit or _exit to ensure the program quit.

adulau commented 6 months ago

Another question, I like the idea of the healthcheck but why not using the introspection directly?

JakubOnderka commented 6 months ago

Question: why do you replace the sys.exit by return ? It’s kind of intended to use an exit or _exit to ensure the program quit.

It will be the same with return.

Another question, I like the idea of the healthcheck but why not using the introspection directly?

You mean /modules request? I think /healthcheck is cleaner way, usually this call is made every 30 seconds inside container, so /modules just consumes CPU for nothing.