UTF encoding causing errors

MISP / misp-modules

Modules for expansion services, enrichment, import and export in MISP and other tools.

http://misp.github.io/misp-modules

GNU Affero General Public License v3.0

345 stars 234 forks source link

UTF encoding causing errors #93

Closed seamustuohy closed 7 years ago

seamustuohy commented 7 years ago

After a casual mention by @Rafiot that UTF encoding caused errors when importing emails in the e-mail import module I created some unit-tests so I could figure out how to fix it. Yet, the unit-tests will not fail under UTF 8, 16, or 32 in the body or the headers. So, I am adding this issue so @Rafiot can attach a failing e-mail and I can reproduce the aforementioned UTF issues.

Rafiot commented 7 years ago

I need to try that again, I may have fixed it there: https://github.com/MISP/misp-modules/commit/1051e2210b65be4c215c3ad17e46a624eb0081cb which was due to the removal of mode='U' in python3.6: https://docs.python.org/3/library/zipfile.html#zipfile.ZipFile.open

Rafiot commented 7 years ago

Fixed