search

MISP / misp-objects

Definition, description and relationship types of MISP objects
https://www.misp-project.org/objects.html
Other
91 stars 118 forks source link

Correct basic grammar in a few areas. #384

Closed rickhenderson closed 1 year ago

rickhenderson commented 1 year ago

I tried not to be too academic, but to me as a native English (Canadian) speaker and writer I have made some suggestions that include simple grammar corrections. Mostly I just added 's' where it needs to be.

This is my first time suggesting a change. Sorry if I am out of line! Just starting to work with MISP.

adulau commented 1 year ago

Thank you very much for the pull-request.

We will include your changes. Just for your information, some text came from the JSON files which automatically generate the description from the README. We will do the changes in the JSON files too. If you see something else later, feel free to edit the JSON directly.

Thanks again for your first contribution to MISP!

adulau commented 1 year ago

Thanks again for your contribution to the MISP project.

I included your changes in the JSON files too: https://github.com/MISP/misp-objects/commit/cd27802aab06f02e9e4d02e74feaec3d73427298

Don't hesitate to make new pull-requests. It's really appreciated.

rickhenderson commented 1 year ago

Thank you so much! I'm looking forward to working more with MISP.