search

MISP / x_old_misp_docker

MISP Docker (XME edition)
283 stars 168 forks source link

Revert "Create the database" #93

Closed stevengoossensB closed 3 years ago

stevengoossensB commented 3 years ago

Reverts MISP/misp-docker#79

Hi @adulau I think we should revert this PR back to the @xme version. I have been continuing the work on a new container instance which uses the MISP install script, but I think we should take this as a separate track/container implementation in a different Git project.

jellard1 commented 3 years ago

Merge it! Go, go, go! -says the guy who just discovered this issue 15 minutes ago. It's been broken since July? Well looks like I ran into this right as you were fixing it! Can you merge @helinko or only @stevengoossensB can?

helinko commented 3 years ago

I don't have commit rights and neither does @stevengoossensB, I assume. @adulau at least has. In the meantime you can just use the branch from Steven's fork of the repo.

helinko commented 3 years ago

Only now tested the nginx version and that seems broken. Do you know whether it was like that before the initial merge?

stevengoossensB commented 3 years ago

What error message are you getting? I'm not using any of the compose versions since I'm running it on Azure and have created my template there and use the infra there for reverse proxying.

stevengoossensB commented 3 years ago

Only now tested the nginx version and that seems broken. Do you know whether it was like that before the initial merge?

Nvm, I found an error in the NGINX config where it redirected to misp_web, while it should be web. Could you retry?

helinko commented 3 years ago

Yeah I think that's an error, as curling from the proxy container returns 400 for misp_web but web works as expected. However, there's something also broken in the nginx config since it still goes to the "Proxy Backend Not Found" custom error page.

I don't know enough about nginx to see right away what's wrong, but I'll continue debugging tomorrow if no one else has found a fix.

helinko commented 3 years ago

The http->https rewrite rule is broken and I have a fix for it, plus a couple of other improvements. It's not really in the scope of this PR though, since you haven't touched that part at all. So maybe I'll just make a new PR about it?

adulau commented 3 years ago

Let us know if this is fine ;-)