Closed connor-makowski closed 2 months ago
@connor-makowski @mrkwanzaa Any suggestions for improvement? Also, I was wondering if it is possible to make all of the bars/line segments the same color, as that is usually standard for PDF/CDF charts.
This looks really good, and they're working great! I have a few small notes but overall excellent job.
chartMaxGroupings
found in utils/enums.js
should fix this.As far as the coloring goes, you can specify the coloring
parameter when you base the data to the BaseChart component, or do something more custom (eg add a colorSame prop to BaseChart) if you feel that's cleaner from a code side.
Looking good so far.
Regarding the colors, lets think about that a bit more.
I think we will need a new always available grouping structure (like None - which is really just one big group) for each element - meaning each element is its own group. For naming, we might have something like All
which is the current None
and None
which is actually individual elements.
This could be useful for all charts considering we now have filters per chart and can filter down to very granular data.
@mrkwanzaa I could see a number of potential rammifications here, but if we default no grouping selection to All
then I think we could avoid any breaking changes. This however represents a hardcoded element. Do you see any other potential for breaking changes here?
@connor-makowski @mrkwanzaa I've made a lot of adjustments to the distribution charts; let me know if you have any additional thoughts! Thanks.
Those are coming along really well!!! It is making me rethink some of our future charting developments. The only thing I see left for this issue is figuring out how to better represent the buckets from a UI perspective and where to place the num buckets slider.
I'm also a big fan of how these are turning out. The only obvious issues I'm seeing is that if you subgroup the legend overlaps with the buckets slider, and sometime the pdf/cdf dropdown starts scrolling (I'm guessing this is related to #502 ).
Moved slider to bottom of chart: fe56d6a
Closing after merging #519
These charts should include both bar and line charts as well as cover both PDF and CDF with different bucket sizes. I am all ears for a UI/UX proposal here.