search

MIT-CAVE / cave_static

A react based static web app to be used as a UI and data consumer for the CAVE app.
Apache License 2.0
0 stars 1 forks source link

Marquee scroll fix #517

Closed ayang0675 closed 2 months ago

ayang0675 commented 2 months ago

marquee scrolls only when units don't fit in the box.

connor-makowski commented 2 months ago

@luisvasq can you check this out and merge if it makes sense to you?

luisvasq commented 2 months ago

This will be a useful fix. While looking into this, I noticed that some marquee-ing values, as shown below, may disappear when the OverflowText component is initially mounted.

no-value-in-marquee

luisvasq commented 2 months ago

@ayang0675, let me know if I can help with anything here!

ayang0675 commented 2 months ago

@luisvasq Thanks so much for catching that. How do i get to this screen?

luisvasq commented 2 months ago

@luisvasq Thanks so much for catching that. How do i get to this screen?

Of course. While on the first dashboard page of the kitchen_sink example, click on the reset button and you should see the values ​​disappear.

ayang0675 commented 2 months ago

@luisvasq Thanks so much for catching that. How do i get to this screen?

Of course. While on the first dashboard page of the kitchen_sink example, click on the reset button and you should see the values ​​disappear.

i think the issue is fixed now

connor-makowski commented 2 months ago

@luisvasq can you verify this and merge if everything checks out.

luisvasq commented 2 months ago

@luisvasq can you verify this and merge if everything checks out.

LGTM! Nice job, @ayang0675. Merging now.