search

MIT-CAVE / cave_static

A react based static web app to be used as a UI and data consumer for the CAVE app.
Apache License 2.0
0 stars 1 forks source link

Optimize number input update #523

Closed brianzheng205 closed 2 weeks ago

brianzheng205 commented 3 weeks ago

The number input currently waits for the server to update its value locally, which causes a slight, undesirable update.

brianzheng205 commented 2 weeks ago

@connor-makowski Should I go ahead and start working on this?

connor-makowski commented 2 weeks ago

Yes please. Lets go ahead and add this into 2.3.0

brianzheng205 commented 2 weeks ago

@connor-makowski I updated it to first use the new value locally and update the value if necessary once the server changes defaultValue.

connor-makowski commented 2 weeks ago

Is there a PR or commit hash that you can link here?

brianzheng205 commented 2 weeks ago

https://github.com/MIT-CAVE/cave_static/commit/b3ff6ee336b6a87dc8788be2b6677e03cd2b8b3f

connor-makowski commented 2 weeks ago

See PR: https://github.com/MIT-CAVE/cave_static/pull/530