search

MIT-CAVE / cave_static

A react based static web app to be used as a UI and data consumer for the CAVE app.
Apache License 2.0
0 stars 1 forks source link

2.3.0 dev virtual keyboard #529

Closed connor-makowski closed 1 month ago

luisvasq commented 1 month ago

@brianzheng205, @connor-makowski: I pushed some minor styling updates and took an opinionated approach to separate shift from caps behavior. Essentially, shift will enable uppercase letters and provide access to special characters, while caps will only enable uppercase letters. I tried to emulate the conventional keyboard behavior when combining shift with caps.

Brian, great job with this super useful feature! If you notice anything off after my changes, feel free to fix it if you have time. Otherwise, I'd fix any potential bug(s) on Friday. I'll merge soon...

luisvasq commented 1 month ago

I quickly resolved the conflicts before the merge and realized that the fix for #530 is broken for virtual keyboard input. @brianzheng205: since you worked on that issue, could you check it out? Lmk if I can help with anything.

brianzheng205 commented 1 month ago

@luisvasq Sure! I'll look into it.

brianzheng205 commented 1 month ago

@luisvasq Bug should be fixed.

luisvasq commented 1 month ago

@brianzheng205, nice fix. :100: We're ready to merge.