Closed connor-makowski closed 1 month ago
I quickly resolved the conflicts before the merge and realized that the fix for #530 is broken for virtual keyboard input. @brianzheng205: since you worked on that issue, could you check it out? Lmk if I can help with anything.
@luisvasq Sure! I'll look into it.
@luisvasq Bug should be fixed.
@brianzheng205, nice fix. :100: We're ready to merge.
@brianzheng205, @connor-makowski: I pushed some minor styling updates and took an opinionated approach to separate
shift
fromcaps
behavior. Essentially,shift
will enable uppercase letters and provide access to special characters, whilecaps
will only enable uppercase letters. I tried to emulate the conventional keyboard behavior when combiningshift
withcaps
.Brian, great job with this super useful feature! If you notice anything off after my changes, feel free to fix it if you have time. Otherwise, I'd fix any potential bug(s) on Friday. I'll merge soon...