State Cleanup and Pane Behavior for Virtual Keyboard

MIT-CAVE / cave_static

A react based static web app to be used as a UI and data consumer for the CAVE app.

Apache License 2.0

0 stars 1 forks source link

Closed luisvasq closed 1 month ago

luisvasq commented 1 month ago

Hi Brian,

After a deeper look, I'm logging a couple of items for the virtual keyboard that we should take care of:

[x] Remove the duplicate keyboard group at the root of the Redux state
[x] Keep the pane(s) open while typing on the virtual keyboard or simply when it is displayed. (We should probably handle this in handlePaneClickAway.)

Could you check these and let me know if you have any questions?

Thanks!

brianzheng205 commented 1 month ago

luisvasq commented 1 month ago

@brianzheng205, great job. 💯 I'll merge these changes into 2.3.0-dev.