MIT-LAE / APCEMM

Aircraft Plume Chemistry, Emissions, and Microphysics Model
MIT License
8 stars 17 forks source link

Eigen3 dependencies #8

Closed sdeastham closed 2 months ago

sdeastham commented 1 year ago

It wasn't clear to me why we specify NO_MODULE in the search for Eigen3. I found that Eigen3 could most easily located by first removing NO_MODULE from the CMakeLists.txt file, including the FindEigen3.cmake file (which is provided by the Eigen3 authors) in the cmake directory, and then including the Eigen3 directory in the CMAKE_PREFIX_PATH. Is there a reason this shouldn't become the standard approach? Open to all possibilities (curious to get your thougths @michaelxu3 !)

sdeastham commented 2 months ago

Now resolved - all dependencies handled through vcpkg.