search

MIT-LAE / TASOPT.jl

Medium fidelity aircraft-propulsion system design and optimization.
https://mit-lae.github.io/TASOPT.jl/
MIT License
26 stars 14 forks source link

Improved fuel storage options for cryogenic fuels #23

Closed ngomezve closed 6 months ago

ngomezve commented 6 months ago

This PR revives and revamps fuel storage in a double-walled tank with a vacuum layer. In addition, these changes have been introduced:

codecov-commenter commented 6 months ago

Codecov Report

Attention: Patch coverage is 81.22977% with 58 lines in your changes are missing coverage. Please review.

Project coverage is 74.73%. Comparing base (dfea4bc) to head (3fed201).

:exclamation: Current head 3fed201 differs from pull request most recent head b3fceb2. Consider uploading reports for the commit b3fceb2 to get more accurate results

Files Patch % Lines
src/IO/read_input.jl 12.00% 44 Missing :warning:
src/sizing/wsize.jl 58.33% 5 Missing :warning:
src/structures/tankWmech.jl 97.16% 4 Missing :warning:
src/structures/update_fuse.jl 0.00% 4 Missing :warning:
src/IO/save_model.jl 85.71% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #23 +/- ## ========================================== + Coverage 73.95% 74.73% +0.78% ========================================== Files 70 69 -1 Lines 12984 13093 +109 ========================================== + Hits 9602 9785 +183 + Misses 3382 3308 -74 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

askprash commented 6 months ago

These look like some really awesome additions! 🎉 Thanks @ngomezve!

Looking at all the changes though, these really should to be separate PRs. May have made sense for each one of the bullets below to be their own bite-sized PR. This article may be worth perusing!

This PR revives and revamps fuel storage in a double-walled tank with a vacuum layer. In addition, these changes have been introduced:

  • The user can choose whether to size a cryogenic fuel tank for a given boiloff rate or just use the provided insulation thicknesses.
  • The cabin and fuselage length can be optionally sized for the maximum number of passengers.
  • The cabin can have two decks.
  • The user no longer has to specify fuel temperature and density with cryogenic fuels. These are calculated in read_input().
  • The tests for the fuselage tanks have been expanded.